Attention is currently required from: pespin.

Patch set 2:Code-Review +1

View Change

2 comments:

• File library/RAN_Adapter.ttcnpp:

  • Patch Set #2, Line 120:

    			ba.vc_IPA := IPA_Emulation_CT.create(id & "-IPA") alive;
    			map(ba.vc_IPA:IPA_PORT, system:IPA_CODEC_PT);
    			/* connect MTP3 service provider (IPA) to lower side of SCCP */
    			connect(ba.vc_IPA:MTP3_SP_PORT, ba.vc_SCCP:MTP3_SCCP_PORT);
    			/* connect waiter to general IPA port (for ASP_IPA_Event) */
    			ba.vc_WAIT := IPA_EventWaiter_CT.create(id & "-IPA-WAIT") alive;
    			connect(ba.vc_IPA:IPA_SP_PORT, ba.vc_WAIT:IPA_SP_PORT);
    		
    

    Unneeded indent level? (shift left)

  • Patch Set #2, Line 138:

    			/* wait until we received an IPA CCM ID_ACK */
    			ba.vc_WAIT.done;
    		
    

    Likewise here, why are you adding an indent level?

To view, visit change 41132. To unsubscribe, or for help writing mail filters, visit settings.