Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30575 )
Change subject: Convert ms_first_common_ts to struct gprs_rlcmac_pdch ......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File src/gprs_ms.h:
https://gerrit.osmocom.org/c/osmo-pcu/+/30575/comment/13d4dc04_05578735 PS2, Line 68: _ts
Yes, all integers holding a timeslot number should be called "tn" but they are not right now. […]
Looks like the proper solution would be renaming all timeslot numbers to _tn, and that's outside of scope of this patch / patchset. I think keeping _ts is fine here.
https://gerrit.osmocom.org/c/osmo-pcu/+/30575/comment/f7141c3d_95e740cd PS2, Line 106: _ts
Same here, s/_ts/_pdch/.
marking as resolved, see other discussion