Attention is currently required from: pespin, fixeria.
Patch set 3:Code-Review +1
View Change
2 comments:
File src/gprs_ms.h:
Patch Set #2, Line 68: _ts
Yes, all integers holding a timeslot number should be called "tn" but they are not right now. […]
Looks like the proper solution would be renaming all timeslot numbers to _tn, and that's outside of scope of this patch / patchset. I think keeping _ts is fine here.
Patch Set #2, Line 106: _ts
Same here, s/_ts/_pdch/.
marking as resolved, see other discussion
To view, visit change 30575. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I19373939ec104d371e3e91422f018a8175cb0f89
Gerrit-Change-Number: 30575
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Dec 2022 14:01:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Gerrit-MessageType: comment