Attention is currently required from: pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31610 )
Change subject: vty: msc / codec-list: forbid duplicate entries ......................................................................
Patch Set 1:
(3 comments)
File src/osmo-bsc/bsc_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31610/comment/3e60d27e_7e4ed6d8 PS1, Line 2730: || argv[i][1] != 'r'
this indentation looks wrong.
not mine, just moving code around.
https://gerrit.osmocom.org/c/osmo-bsc/+/31610/comment/86a87b73_d47e2fb3 PS1, Line 2731: || (argv[i][0] != 'h' && argv[i][0] != 'f')
comparing first argv[i][0] and after argv[i][1] is way more "expected" ;)
actually i'd prefer strncmp(argv[i], "fr" resp. "hr", 2)
so i agree, but i'm just moving this code.
https://gerrit.osmocom.org/c/osmo-bsc/+/31610/comment/e1a55faa_d7ba9351 PS1, Line 2740: if (strncmp("hr", argv[i], 2) == 0)
tmp[i]. […]
still just moving code