[M] Change in osmo-bsc[master]: vty: msc / codec-list: forbid duplicate entries

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31610 ) Change subject: vty: msc / codec-list: forbid duplicate entries ...................................................................... Patch Set 1: (3 comments) File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31610/comment/3e60d27e_7e4ed6d8 PS1, Line 2730: || argv[i][1] != 'r' not mine, just moving code around. https://gerrit.osmocom.org/c/osmo-bsc/+/31610/comment/86a87b73_d47e2fb3 PS1, Line 2731: || (argv[i][0] != 'h' && argv[i][0] != 'f') actually i'd prefer strncmp(argv[i], "fr" resp. "hr", 2) so i agree, but i'm just moving this code. https://gerrit.osmocom.org/c/osmo-bsc/+/31610/comment/e1a55faa_d7ba9351 PS1, Line 2740: if (strncmp("hr", argv[i], 2) == 0) still just moving code -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31610 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifdc9e04bf1d623da65bfb8a2fddea765601f6d9b Gerrit-Change-Number: 31610 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 01 Mar 2023 22:25:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment