Attention is currently required from: pespin.

View Change

3 comments:

• File src/osmo-bsc/bsc_vty.c:

  • Patch Set #1, Line 2730: || argv[i][1] != 'r'

    this indentation looks wrong.

    not mine, just moving code around.

  • Patch Set #1, Line 2731: || (argv[i][0] != 'h' && argv[i][0] != 'f')

    comparing first argv[i][0] and after argv[i][1] is way more "expected" ;)

    actually i'd prefer strncmp(argv[i], "fr" resp. "hr", 2)

    so i agree, but i'm just moving this code.

  • Patch Set #1, Line 2740: if (strncmp("hr", argv[i], 2) == 0)

    tmp[i]. […]

    still just moving code

To view, visit change 31610. To unsubscribe, or for help writing mail filters, visit settings.