Attention is currently required from: lynxis lazus, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39995?usp=email )
Change subject: Improve paging to support Paging Area ID ......................................................................
Patch Set 1:
(3 comments)
File src/osmo-hnbgw/cnlink_paging.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/39995/comment/5bcd51e3_71ebdd73?us... : PS1, Line 167: const char *cnlink_paging_add_ranap(struct hnbgw_cnlink *cnlink, RANAP_CN_DomainIndicator_t domain, const RANAP_PagingIEs_t *paging_ies) what is the purpose of passing the `RANAP_CN_DomainIndicator_t domain` parameter given that below it is just set as: `domain = paging_ies->cN_DomainIndicator;`?
File src/osmo-hnbgw/hnbgw_ranap.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/39995/comment/a39af562_4e09b40d?us... : PS1, Line 328: { RANAP_PagingAreaID_PR_rAI, "RAI" }, why lowercase l and r in lAI and rAI?
https://gerrit.osmocom.org/c/osmo-hnbgw/+/39995/comment/7beaed03_d875abfc?us... : PS1, Line 409: "Rx Paging from CN: decoding RANAP IE Paging Area ID failed\n"); maybe mention in the error msg that it is broadcasting instead? not sure if that would be obvious from log output otherwise