Attention is currently required from: lynxis lazus, pespin.

View Change

3 comments:

• File src/osmo-hnbgw/cnlink_paging.c:

  • Patch Set #1, Line 167: const char *cnlink_paging_add_ranap(struct hnbgw_cnlink *cnlink, RANAP_CN_DomainIndicator_t domain, const RANAP_PagingIEs_t *paging_ies)

    what is the purpose of passing the `RANAP_CN_DomainIndicator_t domain` parameter given that below it is just set as: `domain = paging_ies->cN_DomainIndicator;`?

• File src/osmo-hnbgw/hnbgw_ranap.c:

  • Patch Set #1, Line 328: { RANAP_PagingAreaID_PR_rAI, "RAI" },

    why lowercase l and r in lAI and rAI?

  • Patch Set #1, Line 409: "Rx Paging from CN: decoding RANAP IE Paging Area ID failed\n");

    maybe mention in the error msg that it is broadcasting instead? not sure if that would be obvious from log output otherwise

To view, visit change 39995. To unsubscribe, or for help writing mail filters, visit settings.