Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266 )
Change subject: Pass AMR codec info over L1CTL ......................................................................
Patch Set 2:
(5 comments)
File bts/BTS_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266/comment/8f26b070_ec468... PS2, Line 2513: 0 Can also be made configurable via g_pars.amr_start_codec.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266/comment/b47008be_2acc9... PS2, Line 2521: 00000100 I suggest to make this value configurable via g_pars.amr_codecs.
File library/L1CTL_PortType.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266/comment/bcf59314_2f111... PS2, Line 110: tch_mode_req_tmpl Unusual naming. I would omit the '_tmpl'. Not critical though.
File library/L1CTL_Types.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266/comment/3d617ab8_1a45d... PS2, Line 184: start_codec Either prefix both fields with 'amr_', or wrap into a record:
type record L1ctlTchModeConf { ... // Yes, anonymous records/unions are supported record { uint8_t start_codec, BIT8 codecs_bitmask } amr };
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266/comment/8bea1454_bd0ad... PS2, Line 288: start_codec Same here. You may also define it as a separate record to avoid code dup.