Change in osmo-bsc-nat[master]: Store BSCs

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27472 ) Change subject: Store BSCs ...................................................................... Patch Set 1: Code-Review-1 (3 comments) File include/osmocom/bsc_nat/bsc_nat.h: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27472/comment/5f13e937_5b915965 PS1, Line 43: struct llist_head bscs; /* list of struct bsc */ I think we usually would use bsc_list here, but not critical. File src/osmo-bsc-nat/bsc_nat.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27472/comment/b742658a_0cea154a PS1, Line 94: llist_for_each_entry(bsc, &bsc_nat->bscs, list) { This needs to be for_each_entry_safe AFAICT, otherwise you get a use-after-free. File src/osmo-bsc-nat/bssap.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27472/comment/976c3108_fa01707f PS1, Line 44: bsc = bsc_nat_bsc_add(g_bsc_nat, addr); could this return null? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27472 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Icd7316c49ef26fb45ad45a2ccc1a7916bfb0a387 Gerrit-Change-Number: 27472 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Mar 2022 15:11:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment