Attention is currently required from: osmith.

Patch set 1:Code-Review -1

View Change

3 comments:

• File include/osmocom/bsc_nat/bsc_nat.h:

  • Patch Set #1, Line 43: struct llist_head bscs; /* list of struct bsc */

    I think we usually would use bsc_list here, but not critical.

• File src/osmo-bsc-nat/bsc_nat.c:

  • Patch Set #1, Line 94: llist_for_each_entry(bsc, &bsc_nat->bscs, list) {

    This needs to be for_each_entry_safe AFAICT, otherwise you get a use-after-free.

• File src/osmo-bsc-nat/bssap.c:

  • Patch Set #1, Line 44: bsc = bsc_nat_bsc_add(g_bsc_nat, addr);

    could this return null?

To view, visit change 27472. To unsubscribe, or for help writing mail filters, visit settings.