Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41624?usp=email )
Change subject: enb_proxy: add inital MME pooling support ......................................................................
Patch Set 5:
(2 comments)
File src/enb_proxy.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41624/comment/bcc3acc7_7d296... : PS5, Line 198: close_sock(S),
I wonder why do we close and reconnect here... […]
Here we're closing the socket that was created during previous connection attempt (if any) before creating a new one via `sctp_client:connect/1`.
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41624/comment/5e8909a4_0efa5... : PS5, Line 299: %% XXX: sctp_send_from_mme(Data, S),
what about this?
I think we can remove this line. We don't need to forward the S1 SETUP FAILURE anymore, because we may still have other MMEs to try in the pool.