Attention is currently required from: osmith, pespin.

View Change

2 comments:

• File src/enb_proxy.erl:

  • Patch Set #5, Line 198: close_sock(S),

    I wonder why do we close and reconnect here... […]

    Here we're closing the socket that was created during previous connection attempt (if any) before creating a new one via `sctp_client:connect/1`.

  • Patch Set #5, Line 299: %% XXX: sctp_send_from_mme(Data, S),

    what about this?

    I think we can remove this line. We don't need to forward the S1 SETUP FAILURE anymore, because we may still have other MMEs to try in the pool.

To view, visit change 41624. To unsubscribe, or for help writing mail filters, visit settings.