Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/35782?usp=email )
Change subject: rlcmac: Add new structure to allow passing FN+TN to TBF handling functions ......................................................................
Patch Set 1:
(2 comments)
File src/rlcmac/rlcmac.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/35782/comment/6f0b963a_aa4eda39 PS1, Line 775: (struct gprs_rlcmac_dl_block_ind *) `talloc_zero` is a macro, which does pointer cast for you, so this is not needed
``` #define talloc_zero(ctx, type) (type *)_talloc_zero(ctx, sizeof(type), #type) ```
https://gerrit.osmocom.org/c/libosmo-gprs/+/35782/comment/937d91e4_ce30bc9c PS1, Line 778: OSMO_ASSERT(dlbi); You already dereferenced `dlbi` above, so assert()ing makes no sense. Move above?