Attention is currently required from: pespin.

View Change

2 comments:

• File src/rlcmac/rlcmac.c:

  • Patch Set #1, Line 775: (struct gprs_rlcmac_dl_block_ind *)

    `talloc_zero` is a macro, which does pointer cast for you, so this is not needed

    ```
    #define talloc_zero(ctx, type) (type *)_talloc_zero(ctx, sizeof(type), #type)
    ```

  • Patch Set #1, Line 778: OSMO_ASSERT(dlbi);

    You already dereferenced `dlbi` above, so assert()ing makes no sense. Move above?

To view, visit change 35782. To unsubscribe, or for help writing mail filters, visit settings.