Attention is currently required from: pespin.
falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmocore/+/39276?usp=email )
Change subject: osmo_iofd_register: fix the case of changing fd ......................................................................
Patch Set 2:
(1 comment)
File src/core/osmo_io.c:
https://gerrit.osmocom.org/c/libosmocore/+/39276/comment/42fc86fb_945358ce?u... : PS2, Line 759: if (fd >= 0)
I think you don't even need this "if" line, you can do "iofd->fd = fd;" directly.
No, the conditional is still needed. Users are allowed to set fd earlier and pass -1 to `osmo_iofd_register()`; removing the `if` like you propose would break that case.