Attention is currently required from: pespin.

View Change

1 comment:

• File src/core/osmo_io.c:

  • Patch Set #2, Line 759: if (fd >= 0)

    I think you don't even need this "if" line, you can do "iofd->fd = fd;" directly.

    No, the conditional is still needed. Users are allowed to set fd earlier and pass -1 to `osmo_iofd_register()`; removing the `if` like you propose would break that case.

To view, visit change 39276. To unsubscribe, or for help writing mail filters, visit settings.