Attention is currently required from: osmith, neels, laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712 )
Change subject: Add subscr_conn_fsm ......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File src/osmo-bsc-nat/subscr_conn_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/4ab9845d_ddfb47ad PS6, Line 262: osmo_fsm_inst_state_chg(fi, SUBSCR_CONN_FSM_ST_PROCESSING_ASSIGNMENT_COMPLETE_MDCX_RAN, TIMEOUT_MGW, 0); Did you think about using osmo_tdef_state_timeout instead of passing timers every time? It's easier for readers to find out when timers apply by looking at the top of the file. See for instance nacc_fsm.c in osmo-pcu.git. Not saying it for sure applies here, sometimes it cannot be used depending on how the timers are set, just sharing the possibility.