Attention is currently required from: osmith, neels, laforge, fixeria.

Patch set 6:Code-Review +1

View Change

1 comment:

• File src/osmo-bsc-nat/subscr_conn_fsm.c:

  • Patch Set #6, Line 262: osmo_fsm_inst_state_chg(fi, SUBSCR_CONN_FSM_ST_PROCESSING_ASSIGNMENT_COMPLETE_MDCX_RAN, TIMEOUT_MGW, 0);

    Did you think about using osmo_tdef_state_timeout instead of passing timers every time? It's easier for readers to find out when timers apply by looking at the top of the file. See for instance nacc_fsm.c in osmo-pcu.git. Not saying it for sure applies here, sometimes it cannot be used depending on how the timers are set, just sharing the possibility.

To view, visit change 27712. To unsubscribe, or for help writing mail filters, visit settings.