22 Mar
2024
22 Mar
'24
10:09 a.m.
Attention is currently required from: fixeria.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/36383?usp=email )
Change subject: contrib/jenkins.sh: add 'distcheck' job to check package
integrity
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
File contrib/jenkins.sh:
https://gerrit.osmocom.org/c/pysim/+/36383/comment/9507cfd1_3603b162
PS2, Line 35: "distcheck")
Well, it's a distribution integrity check. Yes,
it's not exactly identical to what automake is doing when running make check, but
still I see nothing wrong calling it this way. Can rename to smoketest if you guys like.
I'm fine with both, just was slightly confused initially that it is called distcheck.
No, I am not planning to extend it. I just thought it
would be cleaner to have a separate job for this additional check, so that one could
quickly see what exactly is causing the build verification failure. The existing test is
already doing few things: running unit tests, SIM programming tests, and pySim-trace
tests. Likewise, if you think it's better to run the smoketest there, I can amend the
patch.
That is a good argument for having it in a separate job.
https://gerrit.osmocom.org/c/pysim/+/36383/comment/ea9ee76e_392a3b04
PS2, Line 43: $prog --help > /dev/null
Not sure if printing help would this be useful,
we're mostly interested to catch errors here. […]
Ack. This isn't important
enough to block the patch, we can also remove it later on if we would find it more
useful.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/36383?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic72d58494e8fd0cab8d66ce60f7b70593b770872
Gerrit-Change-Number: 36383
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: char <osmocom(a)hypodyne.net>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 22 Mar 2024 10:09:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment