Attention is currently required from: fixeria.

Patch set 2:Code-Review +2

View Change

2 comments:

• File contrib/jenkins.sh:

  • Patch Set #2, Line 35: "distcheck")

    Well, it's a distribution integrity check. Yes, it's not exactly identical to what automake is doing when running make check, but still I see nothing wrong calling it this way. Can rename to smoketest if you guys like.

    I'm fine with both, just was slightly confused initially that it is called distcheck.

    No, I am not planning to extend it. I just thought it would be cleaner to have a separate job for this additional check, so that one could quickly see what exactly is causing the build verification failure. The existing test is already doing few things: running unit tests, SIM programming tests, and pySim-trace tests. Likewise, if you think it's better to run the smoketest there, I can amend the patch.

    That is a good argument for having it in a separate job.

  • Patch Set #2, Line 43: $prog --help > /dev/null

    Not sure if printing help would this be useful, we're mostly interested to catch errors here. […]

    Ack. This isn't important enough to block the patch, we can also remove it later on if we would find it more useful.

To view, visit change 36383. To unsubscribe, or for help writing mail filters, visit settings.