Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32727 )
Change subject: osmo-bts-trx: implement CSD scheduling support ......................................................................
Patch Set 16:
(3 comments)
Patchset:
PS16:
not super critical, but there still are two unresolved comments regarding magic numbers
Done in a separate patch, see https://gerrit.osmocom.org/c/osmo-bts/+/33726.
File include/osmo-bts/scheduler.h:
https://gerrit.osmocom.org/c/osmo-bts/+/32727/comment/7ad6c67f_fbfe6e9e PS14, Line 135: struct l1sched_meas_set buf[24]; /* up to 24 entries */
it may be good to document here where this 24 comes from.
Done
File include/osmo-bts/scheduler.h:
https://gerrit.osmocom.org/c/osmo-bts/+/32727/comment/24ec218d_8e830f31 PS4, Line 134: struct l1sched_me
This is needed in order to have proper measurements attached to `L1SAP TRAFFIC.ind` primitive. […]
Done