Attention is currently required from: laforge, pespin.

View Change

3 comments:

• Patchset:

  • Patch Set #16:

    not super critical, but there still are two unresolved comments regarding magic numbers

    Done in a separate patch, see https://gerrit.osmocom.org/c/osmo-bts/+/33726.

• File include/osmo-bts/scheduler.h:

  • Patch Set #14, Line 135: struct l1sched_meas_set buf[24]; /* up to 24 entries */

    it may be good to document here where this 24 comes from.

    Done

• File include/osmo-bts/scheduler.h:

  • Patch Set #4, Line 134: struct l1sched_me

    This is needed in order to have proper measurements attached to `L1SAP TRAFFIC.ind` primitive. […]

    Done

To view, visit change 32727. To unsubscribe, or for help writing mail filters, visit settings.