9 Oct
2023
9 Oct
'23
2:12 p.m.
Attention is currently required from: fixeria, pespin.
arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/33201?usp=email )
Change subject: stream: Add and use helper function osmo_ipa_push_headers()
......................................................................
Patch Set 21:
(3 comments)
File include/osmocom/netif/ipa.h:
https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/b47e2a42_6755dcd6
PS20, Line 6: #include <osmocom/netif/stream.h>
This header file contains a protocol definition, and
making it contain the whole stream API does not […]
Done
File src/ipa.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/7ede88bc_d251f762
PS20, Line 443: struct msgb *msg
If we go for exposing this API (see my other comment),
the `msg` pointer should become the first arg […]
Done
https://gerrit.osmocom.org/c/libosmo-netif/+/33201/comment/bdd42606_87f1ac99
PS20, Line 456: osmo_ipa_stream_srv_send
I agree with fixeria here, I already shared my
concerns about this kind of API ;)
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33201?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I61e1fe59166c46595efe8c1f32b8f2607cb6c529
Gerrit-Change-Number: 33201
Gerrit-PatchSet: 21
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 09 Oct 2023 12:12:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment