Attention is currently required from: falconia.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/34449?usp=email )
Change subject: SMS over GSUP: implement forwarding of MO SMS ......................................................................
Patch Set 2:
(1 comment)
File src/hlr_sms.c:
https://gerrit.osmocom.org/c/osmo-hlr/+/34449/comment/e10b85a1_92d03ba9 PS2, Line 136: char smsc_addr[21];
I am not able to find a definition for maximum SMSC-address length anywhere in libosmocore headers.
libsmpp34/src/smpp34_structs.h 31:#define ADDRESS_LENGTH 21
Though that may be from SMPP 3.4 specifications, not GSM whatever specifics (though they may be related). So up to you, but it probably makes sense to just use the ADDERSS_LENGTH from libsmpp34 there?