Attention is currently required from: falconia.
View Change
1 comment:
File src/hlr_sms.c:
Patch Set #2, Line 136: char smsc_addr[21];
I am not able to find a definition for maximum SMSC-address length anywhere in libosmocore headers.
libsmpp34/src/smpp34_structs.h
31:#define ADDRESS_LENGTH 21
Though that may be from SMPP 3.4 specifications, not GSM whatever specifics (though they may be related). So up to you, but it probably makes sense to just use the ADDERSS_LENGTH from libsmpp34 there?
To view, visit change 34449. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: Iaad4531922c41583d261c79f42561a1bdbe03521
Gerrit-Change-Number: 34449
Gerrit-PatchSet: 2
Gerrit-Owner: falconia <falcon@freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: falconia <falcon@freecalypso.org>
Gerrit-Comment-Date: Mon, 18 Sep 2023 15:15:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <falcon@freecalypso.org>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment