Attention is currently required from: arehbein, fixeria.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33083 )
Change subject: gsm/ipa: Add segmentation callback ......................................................................
Patch Set 3:
(1 comment)
File src/gsm/ipa.c:
https://gerrit.osmocom.org/c/libosmocore/+/33083/comment/9c53568a_dbc2c5f8 PS2, Line 730: msg->data_len < total_len
Is `msg->data_len < total_len` really an error? Given that the underlying transport is usually TCP, […]
This (is supposed to) check the case where the msgb is not large enough to contain a complete message.
So e.g. msgb was allocated with a size of 1024, payload_len turns out to be 2342.
I'm not 100% sure if ->data_len is the correct field, though. Do we want msgb_tailroom() + msgb_length() ?