arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30364 )
Change subject: ttcn3-tcpdump*.sh: Fix tcpdump procs not being killed ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
this is now the second time you have set something to +2 without two review +1 existing before. […]
I thought because of the heading in https://projects.osmocom.org/projects/cellular-infrastructure/wiki/Gerrit/ed... that states there are exceptions for 'Urgent patches' (which I was under the impression this was, because it affected Jenkins):
h3. Exceptions for Trivial / Urgent Patches A patch may receive a direct +2 when:
- it is very trivial, like a typo fix in a comment or log string, so that it is not worth wasting review time on.
- it reverts an earlier change that broke the master builds.
that a fixing could be also understood as a case of the second bullet point above (I know better now I suppose), also considering there was a +1 from you.
In the previous case I would have thought it do be a case of the first bullet point above.