Change in libosmocore[master]: coding: add gsm0503_detect_a[fh]s_dtx_frame2()

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28176 ) Change subject: coding: add gsm0503_detect_a[fh]s_dtx_frame2() ...................................................................... Patch Set 2: (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/28176/comment/b8d0bd72_6a55da49 PS2, Line 14: Converting to hard-bits is not really needed. Why? I see you now moved the conversion inside the implementation. Is there a good reason for that? If you end up checking hard-bits, why not passing hard-bits? File src/coding/gsm0503_amr_dtx.c: https://gerrit.osmocom.org/c/libosmocore/+/28176/comment/915cb3ca_0346fcd7 PS2, Line 109: if (*sbits == 0 || id_marker[k] != S2U(*sbits)) I see everywhere you use S2U you also check agianst *sbits==0. Doesn't make it more sense to do "<=" in S2U then? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28176 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibcac395f800bb64150c97fcdaca3523ecfc5fcee Gerrit-Change-Number: 28176 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Comment-Date: Tue, 24 May 2022 10:43:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment