Attention is currently required from: fixeria.

View Change

2 comments:

• Commit Message:

  • Patch Set #2, Line 14: Converting to hard-bits is not really needed.

    Why? I see you now moved the conversion inside the implementation. Is there a good reason for that? If you end up checking hard-bits, why not passing hard-bits?

• File src/coding/gsm0503_amr_dtx.c:

  • Patch Set #2, Line 109: if (*sbits == 0 || id_marker[k] != S2U(*sbits))

    I see everywhere you use S2U you also check agianst *sbits==0. Doesn't make it more sense to do "<=" in S2U then?

To view, visit change 28176. To unsubscribe, or for help writing mail filters, visit settings.