Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/22543 )
Change subject: gsm_7bit_encode_n(): use regular malloc() instead of calloc() ......................................................................
Patch Set 2:
(1 comment)
File src/gsm/gsm_utils.c:
https://gerrit.osmocom.org/c/libosmocore/+/22543/comment/dd46e343_896a80a9 PS1, Line 332: uint8_t *data = malloc(septet_len + 1);
I was thinking about alloca() too, we already use it in src/conv.c. […]
I suggest to stay with the heap allocation for now. alloca() is nice, but it's a more radical change compared to calloc() -> malloc(). I am not confident enough that using the stack here is does not introduce non-obvious pitfalls.