Attention is currently required from: pespin.

View Change

1 comment:

• File src/gsm/gsm_utils.c:

  • Patch Set #1, Line 332: uint8_t *data = malloc(septet_len + 1);

    I was thinking about alloca() too, we already use it in src/conv.c. […]

    I suggest to stay with the heap allocation for now. alloca() is nice, but it's a more radical change compared to calloc() -> malloc(). I am not confident enough that using the stack here is does not introduce non-obvious pitfalls.

To view, visit change 22543. To unsubscribe, or for help writing mail filters, visit settings.