Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27247 )
Change subject: bsc: add TC_ho_into_this_bsc_a5_mismatch ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File bsc/BSC_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27247/comment/b61b5924_d2274... PS2, Line 6032: BSSAP.receive(tr_BSSMAP_HandoverRequestAcknowledge(?)) -> value rx_bssap; I suggest to wrap this 'receive' into an 'alt' statement, move your 'receive' from the above:
alt { [not g_pars.expect_ho_fail] BSSAP.receive(tr_BSSMAP_HandoverRequestAcknowledge(?)) -> value rx_bssap; [g_pars.expect_ho_fail] BSSAP.receive(tr_BSSMAP_HandoverFailure) -> value rx_bssap { // For now just accept any cause BSSAP.receive(tr_BSSMAP_ClearRequest); setverdict(pass); return; } }
This looks cleaner to me. We may also want to add a guard timer.