Attention is currently required from: neels.

Patch set 2:Code-Review +1

View Change

1 comment:

• File bsc/BSC_Tests.ttcn:

  • Patch Set #2, Line 6032: BSSAP.receive(tr_BSSMAP_HandoverRequestAcknowledge(?)) -> value rx_bssap;

    I suggest to wrap this 'receive' into an 'alt' statement, move your 'receive' from the above:

      alt {
      [not g_pars.expect_ho_fail] BSSAP.receive(tr_BSSMAP_HandoverRequestAcknowledge(?)) -> value rx_bssap;
      [g_pars.expect_ho_fail] BSSAP.receive(tr_BSSMAP_HandoverFailure) -> value rx_bssap {
        // For now just accept any cause
        BSSAP.receive(tr_BSSMAP_ClearRequest);
        setverdict(pass);
        return;
        }
      }

    This looks cleaner to me. We may also want to add a guard timer.

To view, visit change 27247. To unsubscribe, or for help writing mail filters, visit settings.