Attention is currently required from: Hoernchen, fixeria, laforge, osmith, pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email )
Change subject: build: add --disable-multi-arfcn configure option ......................................................................
Patch Set 7:
(3 comments)
File Transceiver52M/arch/common/Makefile.am:
https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/fb9e9c46_e48ef71f?usp=... : PS6, Line 9: mult.h
fyi, you can usually do this to avoid touching too many lines with each patch: […]
Thanks for the tip — I've applied that in the current patch.
File Transceiver52M/radioInterface.h:
https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/4a95ccbd_699461d1?usp=... : PS6, Line 165: #ifdef ENABLE_MULTI_ARFCN
What about splitting this subclass into a separate header instead in a previous commit?
Good point — I've moved the subclass into a separate header. I also added include guards in `radioInterface.h` and `radioBuffer.h` I didn't use `#pragma once`, since the codebase mostly uses traditional `#ifndef`/`#define` guards.
File configure.ac:
https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/223f009a_e94ccf0c?usp=... : PS6, Line 308: AC_DEFINE([ENABLE_MULTI_ARFCN],[1],[Building with enabled Multi ARFCN])
Please indent these 2 lines.
Thanks, fixed the indentation.