Attention is currently required from: Hoernchen, fixeria, laforge, osmith, pespin.

View Change

3 comments:

• File Transceiver52M/arch/common/Makefile.am:

  • Patch Set #6, Line 9: mult.h

    fyi, you can usually do this to avoid touching too many lines with each patch: […]

    Thanks for the tip — I've applied that in the current patch.

• File Transceiver52M/radioInterface.h:

  • Patch Set #6, Line 165: #ifdef ENABLE_MULTI_ARFCN

    What about splitting this subclass into a separate header instead in a previous commit?

    Good point — I've moved the subclass into a separate header. I also added include guards in `radioInterface.h` and `radioBuffer.h` I didn't use `#pragma once`, since the codebase mostly uses traditional `#ifndef`/`#define` guards.

• File configure.ac:

  • Patch Set #6, Line 308: AC_DEFINE([ENABLE_MULTI_ARFCN],[1],[Building with enabled Multi ARFCN])

    Please indent these 2 lines.

    Thanks, fixed the indentation.

To view, visit change 42243. To unsubscribe, or for help writing mail filters, visit settings.