15 Feb
2025
15 Feb
'25
10:11 p.m.
Attention is currently required from: neels.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38489?usp=email )
Change subject: vlr: when receiving imsi detach, purge the subscriber towards HLR ......................................................................
Patch Set 6:
(1 comment)
File src/libvlr/vlr.c:
https://gerrit.osmocom.org/c/osmo-msc/+/38489/comment/b274bdaf_7c8847ba?usp=... : PS5, Line 1523: rc |= vlr_subscr_detach(vsub);
(for me personally, '|=' on int type indicates some sort of bitmask logic; here it seems to be boole […]
I made vlr_subscr_detach() a void, because it doesn't has an error path.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38489?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9c2569c45e69b422ce26050b682e6eb26c1c2625
Gerrit-Change-Number: 38489
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Comment-Date: Sat, 15 Feb 2025 22:11:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels nhofmeyr@sysmocom.de