Attention is currently required from: neels.
View Change
1 comment:
File src/libvlr/vlr.c:
Patch Set #5, Line 1523: rc |= vlr_subscr_detach(vsub);
(for me personally, '|=' on int type indicates some sort of bitmask logic; here it seems to be boole […]
I made vlr_subscr_detach() a void, because it doesn't has an error path.
To view, visit change 38489. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9c2569c45e69b422ce26050b682e6eb26c1c2625
Gerrit-Change-Number: 38489
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus <lynxis@fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Comment-Date: Sat, 15 Feb 2025 22:11:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de>