Attention is currently required from: laforge.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/35731?usp=email )
Change subject: add SAIP template handling + v3.1 definitions
......................................................................
Patch Set 1:
(2 comments)
File pySim/esim/saip/templates.py:
https://gerrit.osmocom.org/c/pysim/+/35731/comment/6ad8d394_7faa632d
PS1, Line 23: __init__
cosmetic: too many params, may of which are optional. I would go for `**kw` here:
```
def __init__(self, fid:int, name:str, ftype: str, **kw):
# ...
self.foo = kw.get('foo') # defaults to None
self.bar = kw.get('bar', True) # defaults to True
```
https://gerrit.osmocom.org/c/pysim/+/35731/comment/f66bf293_989183cf
PS1, Line 531: FilesUsimDf5GSv2
duplicate definition
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/35731?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I79bc0a480450ca2de4b687ba6f11d0a4ea4f14c8
Gerrit-Change-Number: 35731
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 29 Jan 2024 02:24:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment