[M] Change in pysim[master]: transport/pcsc: Allow opening PC/SC readers by a regex of their name

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34960?usp=email ) Change subject: transport/pcsc: Allow opening PC/SC readers by a regex of their name ...................................................................... Patch Set 2: (2 comments) File pySim/transport/pcsc.py: https://gerrit.osmocom.org/c/pysim/+/34960/comment/aaf1e628_331b7156 PS2, Line 50: is_a_number(reader_number): Looks like you always expect `reader_number` to be a string: either with the reader number or a regexp. But why does the type is `Union[int, str]` then? Looking at the type I would expect checking like `if type(reader_number) is int`... https://gerrit.osmocom.org/c/pysim/+/34960/comment/914df167_f35cc43e PS2, Line 132: '--pcsc-device (just a suggestion) maybe keep this argument unchanged (and keep it as `int`), and add another one like `--pcsc-device-regexp` (`type=str`)? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34960?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I983f19c6741904c1adf27749c9801b44a03a5d78 Gerrit-Change-Number: 34960 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 04 Nov 2023 12:01:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment