Attention is currently required from: laforge, fixeria, pespin.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31533 )
Change subject: common: Have PCU socket connection use osmo_wqueue ......................................................................
Patch Set 5:
(2 comments)
File include/osmo-bts/pcuif_proto.h:
https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/d0edd8d4_78d2fe9f PS4, Line 7:
ws change, please revert this chunk
Done
File src/common/pcu_sock.c:
https://gerrit.osmocom.org/c/osmo-bts/+/31533/comment/a25ceeba_585fac4f PS2, Line 1102: osmo_fd_write_disable(&state->upqueue.bfd);
Ah alright, good to know (just read a bit into the code/`fd_set`-related matters). […]
@pespin I wrote this because I wanted to make sure the previous code was indeed wrong (as I said, I didn't change the logic with respect to that).
I have looked at some of our projects and seen similar code (code that disables the fd before calling `write` or transmitting data (probably also ultimately calling write) in osmo-trx, osmo-bts and libosmo-abis code.
Probably isn't noticeable because sooner or later, the enable happens, anyways.
Should I still change the code so that the fd is disabled only when there is no data to write anymore (and enabled after data is added to the msg queue)?