Attention is currently required from: laforge, fixeria, pespin.

View Change

2 comments:

• File include/osmo-bts/pcuif_proto.h:

  • Patch Set #4, Line 7:

    ws change, please revert this chunk

    Done

• File src/common/pcu_sock.c:

  • Patch Set #2, Line 1102: osmo_fd_write_disable(&state->upqueue.bfd);

    Ah alright, good to know (just read a bit into the code/`fd_set`-related matters). […]

    @pespin I wrote this because I wanted to make sure the previous code was indeed wrong (as I said, I didn't change the logic with respect to that).

    I have looked at some of our projects and seen similar code (code that disables the fd before calling `write` or transmitting data (probably also ultimately calling write) in osmo-trx, osmo-bts and libosmo-abis code.

    Probably isn't noticeable because sooner or later, the enable happens, anyways.

    Should I still change the code so that the fd is disabled only when there is no data to write anymore (and enabled after data is added to the msg queue)?

To view, visit change 31533. To unsubscribe, or for help writing mail filters, visit settings.