Attention is currently required from: falconia.
pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmocore/+/39276?usp=email )
Change subject: osmo_iofd_register: fix the case of changing fd ......................................................................
Patch Set 1: Code-Review-1
(4 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/39276/comment/c246cfbd_dba1f3ce?u... : PS1, Line 13: osmo_fd_setup(), or if it has changed since then, you can state "or if it has changed since then" I probably missed that part when I caused the regression recently, thanks for noticing.
https://gerrit.osmocom.org/c/libosmocore/+/39276/comment/4b93886b_2c0a0c75?u... : PS1, Line 22: Fixes: df1ee8568b97dbf6d5268a83d1715a1c1fffb2de
File src/core/osmo_io.c:
https://gerrit.osmocom.org/c/libosmocore/+/39276/comment/e18c5373_bd05e625?u... : PS1, Line 760: return iofd->fd == fd ? 0 : -ENOTSUP; since you are not setting iofd->fd in the code path you removed, this check is also wrong now?
https://gerrit.osmocom.org/c/libosmocore/+/39276/comment/0ca71e1b_45f322fe?u... : PS1, Line 761: } else { if clause is an early return, this "else" can be removed and the assignment done directly.