Attention is currently required from: falconia.

Patch set 1:Code-Review -1

View Change

4 comments:

• Commit Message:

  • Patch Set #1, Line 13: osmo_fd_setup(), or if it has changed since then, you can state

    "or if it has changed since then" I probably missed that part when I caused the regression recently, thanks for noticing.

  • Patch Set #1, Line 22:

    Fixes: df1ee8568b97dbf6d5268a83d1715a1c1fffb2de

• File src/core/osmo_io.c:

  • Patch Set #1, Line 760: return iofd->fd == fd ? 0 : -ENOTSUP;

    since you are not setting iofd->fd in the code path you removed, this check is also wrong now?

  • Patch Set #1, Line 761: } else {

    if clause is an early return, this "else" can be removed and the assignment done directly.

To view, visit change 39276. To unsubscribe, or for help writing mail filters, visit settings.