Attention is currently required from: pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42175?usp=email )
Change subject: dfu: MANIFEST_SYNC: stay in MANIFEST_SYNC when manifestationIntolerant & completed ......................................................................
Patch Set 2:
(2 comments)
File usb/class/dfu/device/dfudf.c:
https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42175/comment/705bf41e_eab52ca6... : PS2, Line 188: } else { // this should not happen (after manifestation the state should be dfuMANIFEST-WAIT-RESET if we are not manifest tolerant)
I'll take over this comment, improve the otherwise stay in MANIFEST_SYNC
Done
https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42175/comment/87e5d082_67cbb83a... : PS2, Line 184: if (!dfu_manifestation_complete) {
may make sense to actually switch the if path to be "if (dfu_manifestation_complete)" now.
Done