Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42175?usp=email ) Change subject: dfu: MANIFEST_SYNC: stay in MANIFEST_SYNC when manifestationIntolerant & completed ...................................................................... Patch Set 2: (2 comments) File usb/class/dfu/device/dfudf.c: https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42175/comment/705bf41e_eab52ca6... : PS2, Line 188: } else { // this should not happen (after manifestation the state should be dfuMANIFEST-WAIT-RESET if we are not manifest tolerant)
I'll take over this comment, improve the otherwise stay in MANIFEST_SYNC Done
https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42175/comment/87e5d082_67cbb83a... : PS2, Line 184: if (!dfu_manifestation_complete) {
may make sense to actually switch the if path to be "if (dfu_manifestation_complete)" now. Done
-- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42175?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I8c34a18e2336731126a8c01070d86e2547578e3d Gerrit-Change-Number: 42175 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 24 Feb 2026 14:38:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis@fe80.eu>