Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795 )
Change subject: mgw_fsm: add MGW support to osmo-hnbgw ......................................................................
Patch Set 28:
(2 comments)
File src/osmo-hnbgw/mgw_fsm.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/comment/9f35a32f_0eeac45e PS25, Line 52: /* Send Iu Release request, this is done in errornous cases from which we cannot recover */
typo: errornous-> erroneous
Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/comment/7d888675_2615f3c2 PS25, Line 53: static void tx_release_req(struct hnbgw_context_map *map)
We'd probably want to add a hnbgw_iu.c or alike, but ok, let's keep it here for now.
I think thats a good idea, but I also think that we should do this in a different patch. The planned FSM for the packet RABs will probably also have to send release requests when an error occurs.