Attention is currently required from: pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795 )
Change subject: mgw_fsm: add MGW support to osmo-hnbgw
......................................................................
Patch Set 28:
(2 comments)
File src/osmo-hnbgw/mgw_fsm.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/comment/9f35a32f_0eeac45e
PS25, Line 52: /* Send Iu Release request, this is done in errornous cases from which we
cannot recover */
typo: errornous-> erroneous
Done
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795/comment/7d888675_2615f3c2
PS25, Line 53: static void tx_release_req(struct hnbgw_context_map *map)
We'd probably want to add a hnbgw_iu.c or alike,
but ok, let's keep it here for now.
I think thats a good idea, but I also think
that we should do this in a different patch. The planned FSM for the packet RABs will
probably also have to send release requests when an error occurs.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/26795
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ib9b62e0145184b91c56ce5d8870760bfa49cc5a4
Gerrit-Change-Number: 26795
Gerrit-PatchSet: 28
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 24 Feb 2022 09:58:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment