5 Sep
2025
5 Sep
'25
10:43 a.m.
Attention is currently required from: fixeria, pespin.
osmith has posted comments on this change by osmith. (
https://gerrit.osmocom.org/c/osmo-msc/+/41043?usp=email )
Change subject: gsm48_cc_tx_setup: fix speech bearer capabilities
......................................................................
Patch Set 3:
(4 comments)
File src/libmsc/gsm_04_08_cc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/41043/comment/2afb317b_1b134fdf?usp… :
PS2, Line 994: * - We shall send spares for radio (which happens to be the same as
what's "spares"? "spare bits"?
Done
What do you mean with "radio" here?
'.radio' from the struct (radio channel requirement), clarified it
https://gerrit.osmocom.org/c/osmo-msc/+/41043/comment/60e393ef_f00fa793?usp… :
PS2, Line 997: * - We could send a speech version list in theory that MS are then
"We could in theory send a speech version list
that"
Done
https://gerrit.osmocom.org/c/osmo-msc/+/41043/comment/3c3bb533_715b9a10?usp… :
PS2, Line 1003: .radio = GSM48_BCAP_RRQ_FR_ONLY, /* spare */
If it's a spare, imho it'd be better to add a
hardcoded value, or add an explicit enum field (eg. […]
Done, this patch now depends
on https://gerrit.osmocom.org/c/libosmocore/+/41056
https://gerrit.osmocom.org/c/osmo-msc/+/41043/comment/5b76c735_3d3dd04c?usp… :
PS2, Line 1000: if (bearer_cap.transfer == GSM48_BCAP_ITCAP_SPEECH)
: bearer_cap = (struct gsm_mncc_bearer_cap){
: .transfer = GSM48_BCAP_ITCAP_SPEECH,
: .radio = GSM48_BCAP_RRQ_FR_ONLY, /* spare */
: .speech_ver = { -1 },
: };
:
I suggest to avoid copying the given `struct
gsm_mncc_bearer_cap`: […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41043?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I7046e9244fd9d4301ee2c4df1147a619f753739c
Gerrit-Change-Number: 41043
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Sep 2025 08:43:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>