Attention is currently required from: fixeria, pespin.
4 comments:
File src/libmsc/gsm_04_08_cc.c:
Patch Set #2, Line 994: * - We shall send spares for radio (which happens to be the same as
what's "spares"? "spare bits"?
Done
What do you mean with "radio" here?
'.radio' from the struct (radio channel requirement), clarified it
Patch Set #2, Line 997: * - We could send a speech version list in theory that MS are then
"We could in theory send a speech version list that"
Done
Patch Set #2, Line 1003: .radio = GSM48_BCAP_RRQ_FR_ONLY, /* spare */
If it's a spare, imho it'd be better to add a hardcoded value, or add an explicit enum field (eg. […]
Done, this patch now depends on https://gerrit.osmocom.org/c/libosmocore/+/41056
if (bearer_cap.transfer == GSM48_BCAP_ITCAP_SPEECH)
bearer_cap = (struct gsm_mncc_bearer_cap){
.transfer = GSM48_BCAP_ITCAP_SPEECH,
.radio = GSM48_BCAP_RRQ_FR_ONLY, /* spare */
.speech_ver = { -1 },
};
I suggest to avoid copying the given `struct gsm_mncc_bearer_cap`: […]
Done
To view, visit change 41043. To unsubscribe, or for help writing mail filters, visit settings.