18 Oct
2022
18 Oct
'22
11:31 a.m.
Attention is currently required from: lynxis lazus.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/29788 )
Change subject: Add BTS ramping to prevent mass configuration of BTS at the same time
......................................................................
Patch Set 1:
(4 comments)
File src/osmo-bsc/bsc_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/6d6d0f6e_cbba83fd
PS1, Line 1284: "allow-bts-configuration <0-65535>",
Unfortunately we have a mix of two different command styles: a) 'COMMAND
<0-255>' and b) 'bts <0-255> COMMAND'. Personally I find b) more
logical and suggest to use it for the new command. For example, see
bts_resend_sysinfo_cmd.
https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/c50b2ece_d3427ec3
PS1, Line 1284: 65535
Not sure if OML allows to address more than 256 BTS instances, but ok.
https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/0007d035_73d8e375
PS1, Line 3087: bts ramp limit
I suggest to rework this command as follows:
bts-ramp # "Configure BTS ramping parameters\n"
limit <0-999> # "Limit number of BTS\n" "Number of BTS\n"
window <0-999> # "Time window\n" "Time window (in
seconds)\n"
File src/osmo-bsc/nm_bts_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/a165e573_e4a541bc
PS1, Line 92: struct gsm_bts *bts,
weird [mis]alignment
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d
Gerrit-Change-Number: 29788
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 18 Oct 2022 09:31:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment